Skip to content

fix(android): controls always show in fullscreen#4907

Open
janpe wants to merge 2 commits into
TheWidlarzGroup:support/6.x.xfrom
janpe:fix/android-fullscreen-controls
Open

fix(android): controls always show in fullscreen#4907
janpe wants to merge 2 commits into
TheWidlarzGroup:support/6.x.xfrom
janpe:fix/android-fullscreen-controls

Conversation

@janpe
Copy link
Copy Markdown

@janpe janpe commented May 27, 2026 •
edited
Loading

Fixes #4734
Closes #4751

Summary

This is a rebase of the stale PR #4813 by @robertert (preserved as the first commit, original authorship intact), with the second commit addressing the review feedback from @moskalakamil:

  • Drop the two inline explanatory comments
  • Inline the shouldShowControls boolean in updateControllerVisibility
  • Replace the explicit updateControllerConfig() + exoPlayerView.showController() on fullscreen entry with refreshControlsStyles(), which (after the first commit removes the !controls guard) refreshes visibility unconditionally

@janpe
Copy link
Copy Markdown
Author

janpe commented May 27, 2026

I'm open to closing this issue if @robertert's PR #4813 moves forward

There are failing checks but that seems like a pre-existing issue on the v6 branch

@janpe janpe mentioned this pull request May 27, 2026
Open
@janpe
Copy link
Copy Markdown
Author

janpe commented May 28, 2026

Heads up for reviewers: the red CI is unrelated to this change. The job fails at yarn install before the Android build runs, because mute-stream@4.0.0 was recently published with engines.node >= 22 and the workflow pins node-version: 20.x. Since there's no yarn.lock in the repo, fresh installs now resolve to the incompatible version.

Last green Build Android on support/6.x.x: run 26196236832 (2026-05-20). Anything merged into this branch after that point will hit the same failure until the workflow bumps Node (or a lockfile is added).

cc @moskalakamil — you approved #4813; this PR cherry-picks that commit (authorship preserved) and adds a second commit addressing your review nits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

React Native Video - Public Roadmap
Status: To Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janpe @robertert